When forming questions in English, remember that the verb usually precedes the subject in yes/no questions. In WH-questions, the question word comes first.
The proper sentence structure is "What is your favourite colour?" This sentence correctly positions the subject after the verb "is," adhering to the conventional question format.